RFR: 8044609: javax.net.debug options not working and documented as expected [v4]

Sean Coffey coffeys at openjdk.org
Wed Sep 4 08:25:29 UTC 2024


On Wed, 4 Sep 2024 03:18:33 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8044609-ssl
>>  - Merge branch 'master' into 8044609-ssl
>>  - all ssl mode only if ssl specified by itself
>>  - Merge branch 'master' into 8044609-ssl
>>  - indentation
>>  - Allow ssl,<option> type syntax as currently done. Improve test case coverage
>>  - Tighten up ssl parsing
>>  - remove file
>>  - Initial commit
>
> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 104:
> 
>> 102:         System.err.println("\thandshake    print each handshake message");
>> 103:         System.err.println("\tkeymanager   print key manager tracing");
>> 104:         System.err.println("\tpluggability print pluggability tracing");
> 
> Shouldn't this just be removed completely, or marked with "(obsolete)" and moved to the bottom?

good catch. Looks like there hasn't been a use case for years with this option. Removed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r1743289696


More information about the security-dev mailing list