RFR: 8298420: PEM API: Implementation (Preview) [v4]

Anthony Scarpino ascarpino at openjdk.org
Wed Sep 4 17:13:23 UTC 2024


On Thu, 29 Aug 2024 19:35:25 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   pemrecord whitespace
>
> src/java.base/share/classes/java/security/PEMEncoder.java line 183:
> 
>> 181:                 }
>> 182:             }
>> 183:             case Certificate c -> {
> 
> Shouldn't this be `X509Certificate` and `X509CRL` for line 191 since those are the permitted `DerEncodable` subtypes? I'm assuming it would be an error (compiler?) to try to pass in other subtypes.

Yes the upcoming update fixes this

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1744150331


More information about the security-dev mailing list