RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v22]

[Viktor Klang]

On Fri, 30 Aug 2024 23:26:12 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic algorithms for deriving additional keys from a secret key and other data. See [JEP 478](https://openjdk.org/jeps/478).
>> 
>> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
>
> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change impl class to use byte arrays rather than SecretKey objects where possible

src/java.base/share/classes/javax/crypto/KDF.java line 354:

> 352:                     continue;
> 353:                 }
> 354:                 if (t.hasNext()) {

Looks like you can eliminate the `continue;` if you go with if-elses all the way.

Suggestion:

                } else if (t.hasNext()) {

src/java.base/share/classes/javax/crypto/KDF.java line 367:

> 365:                             "newInstance failed for the provided "
> 366:                             + "kdfParameters"));
> 367:                 continue;

Given the structure of the loop this statement is a no-op.

Suggestion:

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1745800862
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1745801701