RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]
Kevin Driver
kdriver at openjdk.org
Fri Sep 6 18:18:22 UTC 2024
On Fri, 6 Sep 2024 14:07:47 GMT, Viktor Klang <vklang at openjdk.org> wrote:
>> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 31 additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/master' into kdf-jep-wip
>> # Please enter a commit message to explain why this merge is necessary,
>> # especially if it merges an updated upstream into a topic branch.
>> #
>> # Lines starting with '#' will be ignored, and an empty message aborts
>> # the commit.
>> - several more review comments
>> - change impl class to use byte arrays rather than SecretKey objects where possible
>> - updated delayed provider selection javadoc
>> - review comments
>> - use a delegate record to hold the spi and provider
>> - assorted review comment changes
>> - another round of review comments
>> - consistency with wording for addIKM and addSalt
>> - another round of code review comments
>> - ... and 21 more: https://git.openjdk.org/jdk/compare/f6c197f1...a35e98c9
>
> src/java.base/share/classes/javax/crypto/KDF.java line 165:
>
>> 163: * Returns the algorithm name of this {@code KDF} object.
>> 164: *
>> 165: * @return the algorithm name of this {@code KDF} object
>
> Can the returned value be `null`?
No, this is enforced by the `getInstance` methods, which is why `null` is not explicitly called out as a valid value.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1747537262
More information about the security-dev
mailing list