RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

[Sean Mullan]

On Fri, 23 Aug 2024 21:48:44 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic algorithms for deriving additional keys from a secret key and other data. See [JEP 478](https://openjdk.org/jeps/478).
>> 
>> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
>
> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
> 
>   code review comments and test renaming

src/java.base/share/classes/java/security/KDFParameters.java line 40:

> 38:  * {@link javax.crypto.KDF#getInstance(String, KDFParameters) KDF.getInstance}
> 39:  * methods. The {@code getInstance} method returns a {@code KDF}. The
> 40:  * {@code KDF} that is returned is initialized with the specified parameters.

Suggest combining the above 2 sentences to:

The {@code getInstance} method returns a {@code KDF} that is initialized with the specified parameters.

src/java.base/share/classes/java/security/KDFParameters.java line 43:

> 41:  * <p>
> 42:  * The {@code KDFParameters} used for initialization can be retrieved via
> 43:  * {@link javax.crypto.KDF#getParameters()}.

This should also mention that the parameters may contain additional values. Suggest changing to:

The {@code KDFParameters} used for initialization are returned by {@link javax.crypto.KDF#getParameters()} and may contain additional default or random parameter values used by the underlying KDF algorithm..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1750904131
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1750906731