RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v27]

[Sean Mullan]

On Fri, 6 Sep 2024 18:45:42 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic algorithms for deriving additional keys from a secret key and other data. See [JEP 478](https://openjdk.org/jeps/478).
>> 
>> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
>
> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updated comments around locking mechanism

src/java.base/share/classes/java/security/KDFParameters.java line 39:

> 37:  * the
> 38:  * {@link javax.crypto.KDF#getInstance(String, KDFParameters) KDF.getInstance}
> 39:  * methods. The {@code getInstance} method returns a {@code KDF}.

Suggest combining the above sentences to:

The {@code getInstance} method returns a {@code KDF} that is initialized with the specified parameters.

src/java.base/share/classes/java/security/KDFParameters.java line 45:

> 43:  * parameters were not supplied and can be generated by the {@code KDF}
> 44:  * object, these may be supplied by the implementation. For additional
> 45:  * information, see: {@link javax.crypto.KDF#getParameters()}.

I would simplify this as:

The {@code KDFParameters} used for initialization are returned by {@link javax.crypto.KDF#getParameters()} and may contain additional default or random parameter values used by the underlying KDF implementation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1750917030
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1750917753