RFR: 8338395: Add test coverage for instantiating NativePRNG with SecureRandomParameters

Jamil Nimeh jnimeh at openjdk.org
Tue Sep 10 01:47:04 UTC 2024


On Thu, 15 Aug 2024 09:29:00 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:

> In order to improve performance when instantiating NativePRNG, a dummy constructor was added in the PR: https://github.com/openjdk/jdk/pull/17560 which takes and ignores a `java.security.SecureRandomParameters`, throwing an exception if any parameter is passed.
> 
> This PR adds test coverage for those scenarios where the constructor is called passing a not null parameter.

This looks good to me.  The behavior is slightly different on older JVMs (17), but only in the underlying cause of the NSAE.  Shouldn't matter going forward.

-------------

Marked as reviewed by jnimeh (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20592#pullrequestreview-2291212545


More information about the security-dev mailing list