RFR: 8339560: Unaddressed comments during code review of JDK-8337664

Fernando Guallini fguallini at openjdk.org
Wed Sep 11 13:32:35 UTC 2024


During the code review of [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several non-critical comments were raised but not addressed due to time constraints. This PR includes the following changes:

1. Symantec and Entrust tests now reuse common code. The Distrust.java class contains this reusable code, making it easier to add new tests for distrusted roots in the future.
2. In several instances where an Exception is thrown, it has been replaced with RuntimeException.
3. Many Symantec test certs have already expired. To properly test the distrusted scenario, this change wraps the intermediate and root CA certs in NonExpiringTLSServerCert, which does not validate expiration.
4. Package structure changed:
<img width="225" alt="image" src="https://github.com/user-attachments/assets/a8c8407e-edd3-47dd-84c0-19feb9da3c0f">

-------------

Commit messages:
 - Passing params to parse to Distrust
 - reformatting
 - general refactoring
 - combining Entrust and Symantec distrust tests

Changes: https://git.openjdk.org/jdk/pull/20944/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20944&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339560
  Stats: 932 lines in 26 files changed: 391 ins; 541 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/20944.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20944/head:pull/20944

PR: https://git.openjdk.org/jdk/pull/20944


More information about the security-dev mailing list