RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]

Thu Sep 12 22:00:43 UTC 2024

On Thu, 12 Sep 2024 02:36:52 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> @wangweij: Addressed in https://github.com/openjdk/jdk/pull/20301/commits/82791ac01fb7f597a7e814403261c7a50e8a08df.
>
> We usually clean up the array in a `finally` block if an exception could be thrown in between.

@wangweij: Further changes in https://github.com/openjdk/jdk/pull/20301/commits/07480619a0fccc6b862712d015645421d887b984.

>> @wangweij: Resolved in https://github.com/openjdk/jdk/pull/20301/commits/82791ac01fb7f597a7e814403261c7a50e8a08df.
>
> Thanks. And you don't need to check `if (salt == null` and `if (inputKeyMaterial == null)` in `hkdfExtract` now. Also, change the javadoc for `hkdfExtract` about nulls.

@wangweij: Further changes in https://github.com/openjdk/jdk/pull/20301/commits/07480619a0fccc6b862712d015645421d887b984.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1757637227
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1757637528