RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v33]

[Kevin Driver]

On Fri, 13 Sep 2024 16:23:39 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove explicit zeroing in favor of finally blocks
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 119:
> 
>> 117: 
>> 118:         /**
>> 119:          * Builds an {@code Extract} from the current state of the
> 
> Is it better to say "Builds an Extract object"? Same with the `@return` line and other methods.

@wangweij: Already addressed in https://github.com/openjdk/jdk/pull/20301/commits/f279c7ff11c570fdb7307827bfcd86680a862ae6.

> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 139:
> 
>> 137:          *
>> 138:          * @implNote HKDF implementations will enforce that the length is less
>> 139:          * than 255 * HMAC length.
> 
> Precisely, it's "not greater than".

@wangweij: Yes, important call-out.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1759260577
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1759258653