RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v36]
Weijun Wang
weijun at openjdk.org
Mon Sep 16 17:37:25 UTC 2024
On Mon, 16 Sep 2024 16:59:15 GMT, Kevin Driver <kdriver at openjdk.org> wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 426:
>>
>>> 424: * @throws InvalidAlgorithmParameterException
>>> 425: * if the specified provider does not support a {@code KDFSpi}
>>> 426: * implementation for the specified algorithm and parameters
>>
>> Do not mention `algorithm` in this `@throws`. It's already covered by `@throws NSAE`. Same below.
>
> It is intended to refer to the pair/combination of algorithm and parameters. This wording was chosen by another reviewer.
It that reviewer was me, I'm sorry I changed my mind. The current sentence is a little misleading IMO.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1761580707
More information about the security-dev
mailing list