RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v37]
Kevin Driver
kdriver at openjdk.org
Mon Sep 16 19:11:08 UTC 2024
On Mon, 16 Sep 2024 17:43:15 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> For (2), the name `Delegate` was chosen by another reviewer.
>>
>> For (3), we need a valid IDE formatting spec. In 2024, we should not be manually indenting. I'll attempt to find a way to specify this in IntelliJ's config.
>
> For (2), I'll see if the another reviewer has a comment.
> For (3), my IDE automatically indents 8 chars. It's IntelliJ IDEA of 2024.
I've addressed (1b) (`serviceIterator`) and (3) of your above statements here: https://github.com/openjdk/jdk/pull/20301/commits/ea5ba798819568ca86d639ba6c7a9489d4e66c95.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1761714921
More information about the security-dev
mailing list