RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v36]

[Kevin Driver]

On Mon, 16 Sep 2024 16:42:15 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/KDF.java line 207:
>> 
>>> 205:      * Returns a {@code KDF} object that implements the specified algorithm.
>>> 206:      *
>>> 207:      * @see <a href="#DelayedProviderSelection">Delayed Provider Selection</a>
>> 
>> Put `@see` at the end. Put `@implNote` before `@param`. This is the order they are rendered in HTML javadoc.
>
> Nit. I don't personally see the merit in this comment, since the renderer knows what to do, but I've done as you suggest.

See: https://github.com/openjdk/jdk/pull/20301/commits/ea5ba798819568ca86d639ba6c7a9489d4e66c95.

>> src/java.base/share/classes/javax/crypto/KDF.java line 266:
>> 
>>> 264:      *     list
>>> 265:      * @throws NullPointerException
>>> 266:      *     if the {@code algorithm} or {@code provider} is {@code null}
>> 
>> Remove the `the` word. Same below.
>
> This was here to make it read more like proper English, but I'll remove as you suggest.

See: https://github.com/openjdk/jdk/pull/20301/commits/ea5ba798819568ca86d639ba6c7a9489d4e66c95.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1761711488
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1761711767