RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]
Kevin Driver
kdriver at openjdk.org
Tue Sep 17 21:27:29 UTC 2024
On Mon, 16 Sep 2024 21:05:18 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> @wangweij: No change necessary. Personal opinion. These comments are here to stave off reviewer comments that may suggest doing it differently and to reflect my choice to ease the job of backporters.
>
> This commentary about backporting doesn't belong in the code comments. While it is desirable to avoid dependencies in _APIs_ for features that might be backported, it is acceptable to use new JDK features in the _implementation_, especially if they make the code more efficient, readable, etc.
@seanjmullan: Removed in https://github.com/openjdk/jdk/pull/20301/commits/1798541cea82ec61147dab3dcbc0cb823361abaf.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1764033813
More information about the security-dev
mailing list