RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v44]

[Kevin Driver]

On Thu, 19 Sep 2024 19:46:05 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   DPS refactor to re-enable some declared exceptions in getInstance signatures
>
> src/java.base/share/classes/javax/crypto/KDF.java line 665:
> 
>> 663: 
>> 664:     private static boolean checkSpiNonNull(Delegate d) {
>> 665:         return (d != null && d.spi() != null);
> 
> Can `d.spi() == null` ever happen?

Based upon the most recent DPS refactor, it doesn't look possible any longer, so we could remove it. I don't see the harm in this check being present as a defensive-coding measure though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1769206556