RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v45]

Kevin Driver kdriver at openjdk.org
Mon Sep 23 16:35:08 UTC 2024


On Sun, 22 Sep 2024 13:36:39 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spec wording changes and a few tweaks to DPS
>
> src/java.base/share/classes/javax/crypto/KDF.java line 116:
> 
>> 114:     private Delegate theOne;
>> 115:     //guarded by 'lock'
>> 116:     private Delegate candidate;
> 
> Since `candidate` is never modified, make it `final`.

It is modified and cannot be `final`. Thus, resolving this comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1771764293


More information about the security-dev mailing list