RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v44]

Kevin Driver kdriver at openjdk.org
Mon Sep 23 17:50:19 UTC 2024


On Sat, 21 Sep 2024 14:18:58 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Based upon the most recent DPS refactor, it doesn't look possible any longer, so we could remove it. I don't see the harm in this check being present as a defensive-coding measure though.
>
> If it's useless then remote it. We should be confidence in the logic. Adding unnecessary check will only confuse readers.

Addressed in: https://github.com/openjdk/jdk/pull/20301/commits/315f90e6e8572dfaea0fdb4f5d94452637a7e423.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1771850003


More information about the security-dev mailing list