RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v45]

Kevin Driver kdriver at openjdk.org
Thu Sep 26 21:53:19 UTC 2024


On Tue, 24 Sep 2024 18:14:52 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/315f90e6e8572dfaea0fdb4f5d94452637a7e423.
>
> You can keep the existing `pdebug.println` line. Maybe put a line before lines 608 and 622 as well. When a program terminated with an exception, it's usually OK to just dump the exception there without a comment since it's not handled. In this case, we actually handle the exception, and it's better to add a comment on how we handled it.

Enhanced debug messaging here: https://github.com/openjdk/jdk/pull/20301/commits/c0fa2f612b1b9572f5abcc8e9c5705fe6e1ee632.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1777769733


More information about the security-dev mailing list