RFR: 8309841: Jarsigner should print a warning if an entry is removed [v6]

Weijun Wang weijun at openjdk.org
Mon Sep 30 16:18:14 UTC 2024


On Mon, 30 Sep 2024 13:50:23 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update warning message
>
> test/lib-test/jdk/test/lib/util/JarUtilsTest.java line 59:
> 
>> 57:         JarUtils.deleteEntries(Path.of("a.jar"), "b*");
>> 58:         Asserts.assertEquals(Set.of("c"), content("a.jar"));
>> 59:     }
> 
> You could also add a test where the pattern doesn't match, and a test where there is more than one pattern, and the matching pattern is not the first one.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19599#discussion_r1781414936


More information about the security-dev mailing list