RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

[Martin Balao]

On Wed, 26 Feb 2025 00:21:48 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clear ServicesMap fields in the declared order
>>   
>>   Constructors assign the fields in the same order.
>
> src/java.base/share/classes/java/security/Provider.java line 2078:
> 
>> 2076:         // entries derive from the aliases field, keys are not repeated
>> 2077:         // (case-insensitive comparison) and not equal to the algorithm. For
>> 2078:         // services (still) not added to a ServicesMap, value is an empty map.
> 
> Could we re-write it to summarize the conditions for empty map? It could be easier to read/understand.
> For example: empty map if no aliases or if this service is not yet added to a `ServiceMap`.
> The part of case-insensitive comparision, it's due to the impl of `ServiceKey`, right? Maybe we can simply refer to that no need to describe it here.

We will re-write this comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22613#discussion_r2025412796