RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

[Martin Balao]

On Wed, 26 Feb 2025 00:50:39 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clear ServicesMap fields in the declared order
>>   
>>   Constructors assign the fields in the same order.
>
> src/java.base/share/classes/java/security/Provider.java line 2256:
> 
>> 2254:          * keys with Service::addAliasKey.
>> 2255:          */
>> 2256:         private void generateServiceKeys() {
> 
> nit: move this private method to be with other private methods?

Ok, but public and private methods in the class look interleaved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22613#discussion_r2025512604