RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

[Martin Balao]

On Wed, 26 Feb 2025 01:44:26 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clear ServicesMap fields in the declared order
>>   
>>   Constructors assign the fields in the same order.
>
> src/java.base/share/classes/java/security/Provider.java line 735:
> 
>> 733:         // with the Legacy API. The absence of a service key on this set is an
>> 734:         // indication that the service was either not added or added with the
>> 735:         // Current API. Only algorithm service keys are added to this set.
> 
> nit: I find the sentence "The absence of a service key on this set ... added with Current API" is somewhat redundant. I suppose you mean "not added with the Legacy API or added with the Current API". The first sentence is clear enough and the second sentence doesn't add much value.

It could be that the service was not registered in the ServicesMap (any API) or was registered with the Current API. I made a minor change to the comment to stress the difference.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22613#discussion_r2025528391