RFR: 8349890 : Option -Djava.security.debug=x509,ava breaks special chars [v2]

[Sean Mullan]

On Tue, 1 Apr 2025 16:54:25 GMT, Koushik Muthukrishnan Thirupattur <duke at openjdk.org> wrote:

>> **A DESCRIPTION OF THE PROBLEM :**
>> Enabling -Djava.security.debug=x509,ava affects how special characters in certificates are processed. The expected behavior is that debugging should not interfere with the normal encoding of certificate fields.
>> 
>> **Fix:**
>> The Debugging will no longer interfere with these fields, unless you call toString().
>
> Koushik Muthukrishnan Thirupattur has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8349890: option -Djava.security.debug=x509,ava breaks special chars

src/java.base/share/classes/sun/security/x509/AVA.java line 643:

> 641:     public String toString() {
> 642:         return toKeywordValueString
> 643:             (toKeyword(DEFAULT, Collections.emptyMap()), Boolean.TRUE);

I don't think you need to use `Boolean` here, you can just use the primitive boolean data type as the last parameter, and pass `true`.

src/java.base/share/classes/sun/security/x509/AVA.java line 662:

> 660:      */
> 661:     public String toRFC1779String(Map<String, String> oidMap) {
> 662:         return toKeywordValueString(toKeyword(RFC1779, oidMap), Boolean.FALSE);

Same comment, but pass `false`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24360#discussion_r2027760447
PR Review Comment: https://git.openjdk.org/jdk/pull/24360#discussion_r2027750490