RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v6]

Matthew Donovan mdonovan at openjdk.org
Wed Apr 9 16:41:37 UTC 2025


On Wed, 19 Mar 2025 18:08:40 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Moved the sh file logic to jtreg java test.
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor: space at the end

test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 132:

> 130: 
> 131:                 throw new RuntimeException("Token was present", e);
> 132:             } // else expected

does this comment mean that the received exception `e` is expected or that you're expecting an `else` clause that isn't here yet?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23590#discussion_r2035748171


More information about the security-dev mailing list