RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v2]

Valerie Peng valeriep at openjdk.org
Thu Apr 10 21:50:28 UTC 2025


On Mon, 7 Apr 2025 16:42:14 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added default deriveData method to SSLKeyDerivation interface and
>>   refactored code to remove unused AlgorithmParameterSpec argument.
>
> src/java.base/share/classes/sun/security/ssl/RSAKeyExchange.java line 295:
> 
>> 293: 
>> 294:             @Override
>> 295:             public SecretKey deriveKey(String type) throws IOException {
> 
> How about changing the variable name to `typeNotUsed` like `SSLKeyDerivation.LegacyMasterKeyDerivation`?

Yes, missed this one.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24393#discussion_r2038386660


More information about the security-dev mailing list