RFR: 8350830: Values converted incorrectly when reading TLS session tickets [v2]

Nibedita Jena duke at openjdk.org
Tue Apr 15 07:07:48 UTC 2025


On Wed, 9 Apr 2025 14:13:41 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Nibedita Jena has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor change
>
> test/jdk/sun/security/ssl/SSLSessionImpl/ResumeClientTLS12withSNI.java line 361:
> 
>> 359:         if (resultOnce) {
>> 360:             resultOnce = false;
>> 361:             System.out.println("The format of the SSLEngineResult is: \n" +
> 
> Why is this needed? Wouldn't it be more appropriate to have it outside the logging and just print it out as a description?

This is existing format has been used here. It should print only when logging is on (at moment its true always but if changes to false then its no use to print this description)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24535#discussion_r2043805229


More information about the security-dev mailing list