RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v4]

Martin Balao mbalao at openjdk.org
Thu Apr 17 03:14:14 UTC 2025


> Hi,
> 
> I would like to request a review for the fix of JDK-8350661. In this fix, we translate the native PKCS 11 error code into an `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey` API. With that said, different PKCS 11 libraries may throw different errors and may even (in theory) delay the error until the key is used, as _SunJCE_ does. I believe that this is an improvement but further adjustments may be needed in the future.
> 
> No regressions observed in `test/jdk/sun/security/pkcs11/KDF/TestHKDF.java`.
> 
> Thanks,
> Martin.-

Martin Balao has updated the pull request incrementally with one additional commit since the last revision:

  Inform key sizes in the exception when failing check.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24526/files
  - new: https://git.openjdk.org/jdk/pull/24526/files/89d15ba9..1ffde71f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24526&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24526&range=02-03

  Stats: 14 lines in 2 files changed: 4 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/24526.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24526/head:pull/24526

PR: https://git.openjdk.org/jdk/pull/24526


More information about the security-dev mailing list