RFR: 8348732: SunJCE and SunPKCS11 have different PBE key encodings [v6]

Valerie Peng valeriep at openjdk.org
Fri Apr 18 21:04:51 UTC 2025


> As part of [https://bugs.openjdk.org/browse/JDK-8301553](JDK-8301553), SunPKCS11 provider added support for PBE SecretKeyFactories for `HmacPBESHAxxx` and `PBEWithHmacSHAxxxAndAES_yyy`. These impls produce keys whose encoding contains the PBKDF2 derived bytes. Given that SunJCE provider have supported `PBEWithHmacSHAxxxAndAES_yyy` SecretKeyFactories whose key encoding is the password bytes for long time. Such difference may be very confusing, e.g. using the same KeySpec and same-name SecretKeyFactory (from different providers), the resulting keys have same algorithm and format but different encodings.
> 
> Given that the `P11Mac` and `P11PBECipher` classes already do key derivation internally, these PKCS11 SecretKeyFactories aren't a must-have and are proposed to be removed. I've also aligned the com.sun.crypto.provider.PBEKey class with com.sun.crypto.provider.PPBKDF2KeyImpl class to switch to "UTF-8" when converting the char[] to byte[]. This is to accomodate unicode passwords and given that "UTF-8" encoding is same for ASCII characters, this change should not affect backward compatibility.

Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:

  address review comments from Mark

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24068/files
  - new: https://git.openjdk.org/jdk/pull/24068/files/34e5d4e5..5c73f744

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24068&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24068&range=04-05

  Stats: 10 lines in 2 files changed: 4 ins; 5 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/24068.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24068/head:pull/24068

PR: https://git.openjdk.org/jdk/pull/24068


More information about the security-dev mailing list