RFR: 8325448: Hybrid Public Key Encryption [v14]

Weijun Wang weijun at openjdk.org
Mon Apr 21 14:46:58 UTC 2025


On Fri, 11 Apr 2025 18:42:12 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - put encapsulation in params from getParameters
>>  - receiver must specify all algorithm identifiers
>
> src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line 82:
> 
>> 80:  * public key.
>> 81:  * <li>
>> 82:  * If HPKE modes {@code mode_psk} or {@code mode_auth_psk} are used,
> 
> If you want to use `mode_auth_psk`, do you have to call both `authKey` and `psk` methods? If so, I think it would be more readable if you have a separate paragraph for this mode, indicating calling both methods are required.

OK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2052497133


More information about the security-dev mailing list