RFR: 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms [v3]
Valerie Peng
valeriep at openjdk.org
Mon Apr 28 23:04:50 UTC 2025
On Mon, 28 Apr 2025 18:08:22 GMT, Weijun Wang <weijun at openjdk.org> wrote:
> I mainly don't like the current [hardcoded branches](https://github.com/openjdk/jdk/blob/c54fc08aa3c63e4b26dc5edb2436844dfd3bab7c/src/java.base/share/classes/sun/security/pkcs/PKCS7.java#L754) (and [this one](https://github.com/openjdk/jdk/blob/c54fc08aa3c63e4b26dc5edb2436844dfd3bab7c/src/java.base/share/classes/sun/security/ec/ed/EdDSAParameters.java#L126)) currently inside JDK. I understand they are primarily used as a component of another algorithm and not directly used by end users. There will be more such code when we support preHash ML-DSA and SLH-DSA etc.
So, you will replace these hardcoded branches with these in a separate PR? I agree that it'd be nice to do without the hardcoded internal impls, just not sure if we need to caution people using them as regular MessageDigest algorithms.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24576#issuecomment-2836966712
More information about the security-dev
mailing list