RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v6]

Sean Mullan mullan at openjdk.org
Wed Apr 30 15:20:48 UTC 2025


On Tue, 29 Apr 2025 21:44:26 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API for the HKDF support from JCA/JCE providers.
>> 
>> This is just code refactoring. Known-answer regression test for the internal JSSE HKDF impl is removed as the test vectors are already covered by the HKDF impl in SunJCE provider.
>> 
>> Thanks in advance for the review~
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment about not using the same HKDF instance.

src/java.base/share/classes/sun/security/ssl/Finished.java line 35:

> 33: import java.security.NoSuchAlgorithmException;
> 34: import java.security.ProviderException;
> 35: import java.security.spec.AlgorithmParameterSpec;

Can remove import now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24393#discussion_r2068873590


More information about the security-dev mailing list