RFR: 8209992: Align SSLSocket and SSLEngine Javadocs [v3]

Bradford Wetmore wetmore at openjdk.org
Fri Aug 1 00:43:59 UTC 2025


On Thu, 31 Jul 2025 18:53:20 GMT, Artur Barashev <abarashev at openjdk.org> wrote:

>> Add a javadoc paragraph to SSLSocket.startHandshake() and SSLEngine.beginHandshake() methods explaining behavioral differences between TLSv1.3+ and TLSv1.2- versions.
>
> Artur Barashev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address Brad's code review

A couple minor fixes.

I'll approve next round.

src/java.base/share/classes/javax/net/ssl/SSLEngine.java line 1101:

> 1099:      * dependent. For example, in TLSv1.3 calling this method after the
> 1100:      * connection has been established will force a key update. For prior TLS
> 1101:      * versions it will force a renegotiation (re-handshake).

You should delete 1115-1116, as it's duplicating what you have here.

src/java.base/share/classes/javax/net/ssl/SSLSocket.java line 520:

> 518:      * to flow during this handshake.  When the handshake completes, this
> 519:      * will be signaled with an event.
> 520:      * <P>

On line 524, put inside a {@code IOException}

-------------

PR Review: https://git.openjdk.org/jdk/pull/26484#pullrequestreview-3077251110
PR Review Comment: https://git.openjdk.org/jdk/pull/26484#discussion_r2246633075
PR Review Comment: https://git.openjdk.org/jdk/pull/26484#discussion_r2246634901


More information about the security-dev mailing list