RFR: 8347938: Switch to latest ML-KEM private key encoding [v5]

Weijun Wang weijun at openjdk.org
Mon Aug 4 22:38:06 UTC 2025


On Mon, 4 Aug 2025 21:44:30 GMT, Ben Perez <bperez at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   combine security properties description; remove one test
>
> src/java.base/share/classes/sun/security/provider/ML_DSA.java line 593:
> 
>> 591:         var s1 = deepClone(sk.s1);
>> 592:         mlDsaVectorNtt(s1); //s1 now in NTT domain
>> 593:         int[][] As1 = new int[mlDsa_k][ML_DSA_N];
> 
> Multiarray allocations like this are quite slow - for better performance consider using the `integerMatrixAlloc` method. This also applies to the allocations on L598 and L599

Ah yes, I remember this. Will fix it. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24969#discussion_r2252709647


More information about the security-dev mailing list