RFR: 8364540: Apply @Stable to Shared Secrets

Roger Riggs rriggs at openjdk.org
Tue Aug 5 13:52:03 UTC 2025


On Mon, 4 Aug 2025 17:21:22 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> This PR proposes to update the `SharedSecrets` class in `jdk.internal.access` to annotate all but one static field with the `@Stable` annotation.
> 
> The `@Stable` annotation was added to all static fields except for `javaAWTFontAccess`, which remains unannotated. This is because it can be set using several code paths.
> 
> No tests were changed or added, as this is an internal annotation adjustment with no expected behavioral impact.
> 
> This PR passes `tier1`, `tier2`, and `tier3` testing on multiple platforms.
> 
> In a future follow-up issue, we could identify fields in the implementations of the access classes that, in turn, are stable themselves. When this PR is integrated, it might be possible to remove local copies of access in classes to reduce bytecode size with little or no performance impact. Currently, we do not check the invariant, a field is set only once. This is yet another improvement proposal we could do -- maybe using Stable Values.

Looks good, thanks

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26627#pullrequestreview-3088393663


More information about the security-dev mailing list