RFR: 8244336: Restrict algorithms at JCE layer [v8]

Anthony Scarpino ascarpino at openjdk.org
Mon Aug 11 19:14:15 UTC 2025


On Fri, 8 Aug 2025 18:42:08 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> This enhancement introduces a new security property "jdk.crypto.disabledAlgorithms" which can be leveraged to disable algorithms for JCE/JCA crypto services. For now, only Cipher, KeyStore, MessageDigest, and Signature services support this new security property. The support can be expanded later to cover more services if needed. Note that this security property is meant to disable algorithms irrespective of providers. If the algorithm is found to be disabled, it will be rejected before reaching out to provider(s) for the corresponding implementation(s).
>> 
>> A few implementation notes:
>> 1) The specified security property value is lazily loaded and all changes after it's been loaded are ignored. Invalid entries, e.g. wrong syntax, are ignored and removed. The algorithm name check is case-insensitive. If a disabled algorithm is known to has an object identifier (oid) by JDK, this oid and its aliases is also added to the disabled services.
>> 2) The algorithm name checking impl is based on the sun.security.util.AlgorithmConstraints class, but without the decomposing and different constraints.
>> 3) The hardwiring of NONEwithRSA signature to RSA/ECB/PKCS1Padding cipher in java.security.Signature class is removed. Instead, this is moved to the provider level, i.e. SunJCE and SunPKCS11 provider are changed to claim the NONEwithRSA signature support. Disabling one will not affect the other. 
>> 
>> CSR will be filed once the review is wrapping up.
>> 
>> Thanks~
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments from Artur and updated tests to leverage Utils.runAndCheckException

src/java.base/share/classes/sun/security/util/CryptoAlgorithmConstraints.java line 32:

> 30: import java.security.CryptoPrimitive;
> 31: import java.security.Key;
> 32: import java.security.Security;

nit.. this has become an unused import

src/java.base/share/classes/sun/security/util/CryptoAlgorithmConstraints.java line 68:

> 66:     public static boolean permits(String service, String algo) {
> 67:         String serviceDesc = service + "." + algo;
> 68:         return CryptoHolder.CONSTRAINTS.cachedCheckAlgorithm(serviceDesc);

Efficiency nit:  It's better for byte-code if you remove `serviceDesc` and just do the string concatenation in the parameter for `cachedCheckAlgorithm()`.  `serviceDesc` causes an unnecessary store op and extra load op.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26377#discussion_r2264142579
PR Review Comment: https://git.openjdk.org/jdk/pull/26377#discussion_r2264151915


More information about the security-dev mailing list