RFR: 8325448: Hybrid Public Key Encryption [v23]

Artur Barashev abarashev at openjdk.org
Tue Aug 12 22:17:18 UTC 2025


On Tue, 12 Aug 2025 21:54:48 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/spec/snippet-files/PackageSnippets.java line 31:
>> 
>>> 29: import java.security.KeyPairGenerator;
>>> 30: import java.util.Arrays;
>>> 31: 
>> 
>> Please put a short comment here explaining that the only purpose of this file is to be displayed as a snippet in javadoc of `HPKEParameterSpec` class.
>
> Yes, I can add one. That said, I follow the same convention used in other parts of JDK (search for more `snippet-files/PackageSnippets.java`) and none of them has any comment. I think the naming already implies its purpose.

I see! Thanks for explanation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2271409890


More information about the security-dev mailing list