RFR: 8360882: Tests throw SkippedException when they should fail
ExE Boss
duke at openjdk.org
Wed Aug 20 21:47:42 UTC 2025
On Wed, 20 Aug 2025 19:57:59 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:
> This PR updates `ArtifactResolver.fetchOne()` to throw an IOException instead of SkippedException. This allows tests to determine of a missing "artifact" should be treated as a failed or skipped test.`OpensslArtifactFetcher` is also updated to only throw SkippedException if OpenSSL is not available on the test platform.
test/lib/jdk/test/lib/security/OpensslArtifactFetcher.java line 52:
> 50: *
> 51: * @return openssl binary path of the current version
> 52: * @throws IOException if a valid version of OpenSSL cannot be found
This still also throws `SkippedException`:
https://github.com/openjdk/jdk/blob/ae26c5a24e50584cfa3784c4b7e4cc84a738a530/test/lib/jdk/test/lib/security/OpensslArtifactFetcher.java#L83-L84
Suggestion:
* @throws IOException if a valid version of OpenSSL cannot be found
* @throws SkippedException if OpenSSL is not available on the target platform
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26868#discussion_r2289370584
More information about the security-dev
mailing list