RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException

[Daniel Jeliński]

On Thu, 21 Aug 2025 09:06:39 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

> * cleanup
> * changed tests hiding errors and skips to be different `@test`, so the errors could be thrown
> * tests affected:
>   - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPoly.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestCipherMode.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyNoReuse.java 
>   - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyKAT.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestGCMKeyAndIvCheck.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestCICOWithGCMAndAAD.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestKATForGCM.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipherWrap.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyOutputSize.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphers.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestCICOWithGCM.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipher.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java
>   - /test/jdk/sun/security/pkcs11/Cipher/ReinitCipher.java
>   - /test/jdk/sun/security/pkcs11/Cipher/TestRawRSACipher.java
>   - /test/jdk/sun/security/pkcs11/Cipher/Test4512704.java

test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyKAT.java line 44:

> 42: import javax.crypto.AEADBadTagException;
> 43: import java.nio.ByteBuffer;
> 44: import jdk.test.lib.Convert;

you can also remove the ` * @build jdk.test.lib.Convert` line now

test/jdk/sun/security/pkcs11/Cipher/TestCipherMode.java line 34:

> 32: 
> 33: /*
> 34:  * @test

Suggestion:

 * @test id=AES-GCM

Consider adding meaningful IDs to the tests.

test/jdk/sun/security/pkcs11/Cipher/TestPKCS5PaddingError.java line 116:

> 114:                 } catch (NoSuchAlgorithmException nsae) {
> 115:                     System.out.println("Skipping unsupported algorithm: " +
> 116:                                        nsae);

Did you plan to use SkippedException here as well?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26875#discussion_r2290547128
PR Review Comment: https://git.openjdk.org/jdk/pull/26875#discussion_r2290563773
PR Review Comment: https://git.openjdk.org/jdk/pull/26875#discussion_r2290574218