RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v2]
Daniel Jeliński
djelinski at openjdk.org
Thu Aug 21 12:27:19 UTC 2025
On Thu, 21 Aug 2025 12:24:17 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
>> * cleanup
>> * changed tests hiding errors and skips to be different `@test`, so the errors could be thrown
>> * tests affected:
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPoly.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestCipherMode.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyNoReuse.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyKAT.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestGCMKeyAndIvCheck.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestCICOWithGCMAndAAD.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestKATForGCM.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipherWrap.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyOutputSize.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphers.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestCICOWithGCM.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipher.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java
>> - /test/jdk/sun/security/pkcs11/Cipher/ReinitCipher.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestRawRSACipher.java
>> - /test/jdk/sun/security/pkcs11/Cipher/Test4512704.java
>
> Mikhail Yankelevich has updated the pull request incrementally with two additional commits since the last revision:
>
> - Update TestPKCS5PaddingError.java
> - cleanup and added id to tests
LGTM. Thanks!
-------------
Marked as reviewed by djelinski (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26875#pullrequestreview-3140427993
More information about the security-dev
mailing list