RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v2]
Mikhail Yankelevich
myankelevich at openjdk.org
Thu Aug 21 14:04:58 UTC 2025
On Thu, 21 Aug 2025 13:08:34 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Update TestPKCS5PaddingError.java
>> - cleanup and added id to tests
>
> test/jdk/sun/security/pkcs11/Cipher/TestRSACipher.java line 59:
>
>> 57: Cipher.getInstance(RSA_ALGOS[0], p);
>> 58: } catch (GeneralSecurityException e) {
>> 59: throw new SkippedException("Not supported by provider, skipping");
>
> minor nit: include the not-supported algorithm in the message.
Done in the next commit, same for other comments
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26875#discussion_r2291164069
More information about the security-dev
mailing list