RFR: 8360463: Ambiguity in Cipher.getInstance() specification between NoSuchAlgorithmException and NoSuchPaddingException [v4]

Valerie Peng valeriep at openjdk.org
Thu Aug 21 20:43:54 UTC 2025


On Thu, 21 Aug 2025 20:38:22 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revised the wording again to avoid referring to NoSuchPaddingException
>>   in NoSuchAlgorithmException
>
> src/java.base/share/classes/javax/crypto/Cipher.java line 609:
> 
>> 607:      * @throws NoSuchPaddingException if a {@code CipherSpi} implementation
>> 608:      *         from the specified {@code provider} is found but it does not
>> 609:      *         support the padding scheme
> 
> The wording is correct now. Small nit: the NSAE one uses "but does not" and the NSPE one uses "but it does not". You might want to make them the same.

Yes, will do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26489#discussion_r2292091118


More information about the security-dev mailing list