RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v5]

[Volkan Yazici]

On Thu, 21 Aug 2025 13:17:13 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
>> 
>>  - Javadoc fix
>>  - Cosmetic improvements
>>  - Merge remote-tracking branch 'upstream/master' into jlaNoRepl
>>  - Remove redundant type parameters
>>  - Simplify added null checks
>>  - Avoid code duplication by sprinkling some generics magic
>>  - Group `String` methods by `doReplace` argument
>>  - Merge remote-tracking branch 'upstream/master' into jlaNoRepl
>>  - Replace `requireNonNull` with implicit null checks
>>  - Merge remote-tracking branch 'upstream/master' into jlaNoRepl
>>  - ... and 3 more: https://git.openjdk.org/jdk/compare/a7c0f4b8...7af0f351
>
> src/java.base/share/classes/java/lang/String.java line 1319:
> 
>> 1317:     }
>> 1318: 
>> 1319:     private static <E extends Exception> E malformedInputException(byte[] val, Class<E> exceptionType) {
> 
> This one seems only meaningful for ascii. Should we rename this to maybe `malformedAscii`?

Renamed in a73b446a290.

> test/jdk/java/lang/String/NoReplTest.java line 1:
> 
>> 1: /*
> 
> Should we rename this to `NoReplacementTest`?

Renamed in 17196765c99.

> test/jdk/java/lang/String/NoReplTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
> 
> Suggestion:
> 
>  * Copyright (c) 2022, 2025, Oracle and/or its affiliates. All rights reserved.

Fixed in 17196765c99.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26413#discussion_r2293719199
PR Review Comment: https://git.openjdk.org/jdk/pull/26413#discussion_r2293719925
PR Review Comment: https://git.openjdk.org/jdk/pull/26413#discussion_r2293720263