RFR: 8325448: Hybrid Public Key Encryption [v33]

[Weijun Wang]

On Mon, 25 Aug 2025 18:55:26 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8325448: Hybrid Public Key Encryption
>
> src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line 69:
> 
>> 67:  * {@link #info(byte[])} method by both sides.
>> 68:  * <li>
>> 69:  * To support authentication using a pre-shared key ({@code mode_psk}), the
> 
> "To support" sounds like something more needs to be done to implement it. What about just saying "To authenticate using ..."
> 
> Same comment on lines below.

Yes, that's better. I was just copying the exact titles from the RFC.

> src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line 98:
> 
>> 96:  * <p>
>> 97:  * If an HPKE cipher is initialized without parameters, an
>> 98:  * {@code InvalidKeyException} will be thrown.
> 
> Suggest clarifying which method: "... thrown by the init method."

There are 2 `init` taking an `AlgorithmParameterSpec` object, so I'll just use `the {@code init} method`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2301343666
PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2301350056