RFR: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom

Mikhail Yankelevich myankelevich at openjdk.org
Tue Aug 26 17:24:33 UTC 2025


On Tue, 26 Aug 2025 14:42:52 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:

>> It is set there on purpose. This way it will log to the `System.out` and not `System.err`. Just easier to spot this way. I can add `e` into skipped exception, but it seems to be a bit of an overkill. What do you think?
>
> To me it would look logical to look in the `SkippedException` cause to find the reason why the test was skipped, rather than looking somewhere in stdout

I think both are valuable in our tests specifically, but just for convenience I'll add it to skipped exception too

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26942#discussion_r2301650193


More information about the security-dev mailing list