RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v7]
Roger Riggs
rriggs at openjdk.org
Wed Aug 27 20:49:49 UTC 2025
On Mon, 25 Aug 2025 07:46:59 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> `NoRepl`-suffixed `String` methods denote methods that do not replace invalid characters, but throw `CharacterCodingException` on encounter. This behavior cannot easily be derived from the method footprints, has been a source of confusion for maintainers, and is not uniformly adopted, e.g., `newStringUTF8NoRepl()` and `getBytesUTF8NoRepl()` does *not* throw `CCE`. This PR replaces the `NoRepl` suffix with `NoReplacement` in method names and consistently uses `throws CCE` in method footprints.
>
> Volkan Yazici has updated the pull request incrementally with two additional commits since the last revision:
>
> - Improve "sneaky throws"
> - Improve comment style
Look good, still pretty gnarly but the clever parts are encapsulated.
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26413#pullrequestreview-3161697438
More information about the security-dev
mailing list