RFR: 8360463: Ambiguity in Cipher.getInstance() specification between NoSuchAlgorithmException and NoSuchPaddingException [v6]

[Sean Mullan]

On Fri, 22 Aug 2025 21:48:09 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> This PR is for clarifying the `NoSuchAlgorithmException` and `NoSuchPaddingException` for the `Cipher.getInstance(String transformation, Provider provider)` and `Cipher.getInstance(String transformation, String provider)` methods.
>> 
>> As stated in `javax.crypto.CipherSpi` class, provider has the flexibility to register their implementations through various sub-transformations. As a result, depending on how the providers register the implementation, it may lead to `NoSuchAlgorithmException` or `NoSuchPaddingException`. For example, the provider A registers to support "AES/CBC/PKCS5Padding" vs provider B registers to support "AES" (but would only accept "CBC" and "PKCS5Padding" as the valid input for setting mode and padding). Calling `Cipher.getInstance(...)` with "AES/CBC/NoPadding" against provider A and B would lead to `NoSuchAlgorithmException` and `NoSuchPaddingException`. This javadoc update hope to make it clear.
>> 
>> Thanks in advance for the review~
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Applied javadoc changes to getInstance(String) method and made the impl
>   to match the javadoc

src/java.base/share/classes/javax/crypto/Cipher.java line 560:

> 558:         if (failure instanceof NoSuchPaddingException nspe) {
> 559:             throw nspe;
> 560:         } else {

Small nit, you don't need the else block here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26489#discussion_r2307352028