RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v9]

Volkan Yazici vyazici at openjdk.org
Thu Aug 28 19:43:44 UTC 2025


On Mon, 21 Jul 2025 13:00:03 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Rename `NoReplacement` suffix to `OrThrow`
>>  - Simplify `encodeWithEncoder` and trim long lines
>
> src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 328:
> 
>> 326:      * @throws CharacterCodingException for malformed or unmappable bytes
>> 327:      */
>> 328:     String uncheckedNewString(byte[] bytes, Charset cs) throws CharacterCodingException;
> 
> The docs should mention these two details:
> 1. This method does not replace upon malformed data but fails
> 2. This method does not copy the byte array for validation (can add to the warning)

Confirmed with @liach that his remarks are addressed – resolving this conversation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26413#discussion_r2308371942


More information about the security-dev mailing list