RFR: 8371721: Refactor checkTrusted methods in X509TrustManagerImpl [v2]

[Artur Barashev]

On Mon, 1 Dec 2025 14:57:22 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Artur Barashev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Fix merge errors
>>  - Merge branch 'master' into JDK-8371721
>>    
>>    # Conflicts:
>>    #	src/java.base/share/classes/sun/security/ssl/SSLLogger.java
>>    #	src/java.base/share/classes/sun/security/ssl/X509TrustManagerImpl.java
>>  - 8371721: Refactor checkTrusted methods in X509TrustManagerImpl
>
> src/java.base/share/classes/sun/security/ssl/X509TrustManagerImpl.java line 69:
> 
>> 67: 
>> 68:         SSLLogger.logFine("ssl,trustmanager", "adding as trusted certificates",
>> 69:                 (Object[]) trustedCerts.toArray(new X509Certificate[0]));
> 
> If you'd like to remove the calls to isOn, make sure that the log method call parameters are available without running any extra code. For example, this will always call toArray even if the logging is disabled. This will have impact on the CPU and allocation profile.

Oh, good point, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28275#discussion_r2577467287