RFR: 8369950: TLS connection to IPv6 address fails with BCJSSE due to IllegalArgumentException [v2]

Sergey Chernyshev schernyshev at openjdk.org
Tue Dec 2 16:36:10 UTC 2025


On Tue, 2 Dec 2025 15:36:29 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Sergey Chernyshev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - addressed more review comments
>>  - addressed review comments
>
> test/jdk/javax/net/ssl/HttpsURLConnection/SubjectAltNameIPv6.java line 76:
> 
>> 74:         SSLServerSocketFactory sslssf =
>> 75:             new SimpleSSLContext().get().getServerSocketFactory();
>> 76:         SSLServerSocket sslServerSocket =
> 
> Nit: could you please keep the lines under 80 characters long. There are a few instances in this file

ok.

> test/jdk/javax/net/ssl/HttpsURLConnection/SubjectAltNameIPv6.java line 153:
> 
>> 151:     SubjectAltNameIPv6() throws Exception {
>> 152:         startServer();
>> 153:         startClient();
> 
> Do you think it might be better to call doClientSide here directly?

ok, accepted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28577#discussion_r2581969554
PR Review Comment: https://git.openjdk.org/jdk/pull/28577#discussion_r2581975687


More information about the security-dev mailing list