RFR: 8352728: InternalError loading java.security due to Windows parent folder permissions [v13]

Francisco Ferrari Bihurriet fferrari at openjdk.org
Tue Dec 2 17:08:24 UTC 2025


On Tue, 2 Dec 2025 16:46:42 GMT, Artur Barashev <abarashev at openjdk.org> wrote:

>> Francisco Ferrari Bihurriet has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Address review comments
>>  - Slightly improve ConfigFileTestDirPermissions
>>    
>>    Extract restrictedAcl() AutoCloseable and also use AutoCloseable for the
>>    temporary directory cleanup.
>
> src/java.base/share/classes/java/security/Security.java line 258:
> 
>> 256:                     }
>> 257:                     // We perform symlinks resolution on currentPath under the
>> 258:                     // rationale that the original file writer is the one who
> 
> Nit: "the one who" is used to refer to people, while "the one that" or "the one which" is used for inanimate objects.

By "file writer" I mean the person who wrote the properties file issuing a relative `include` directive. But it is definitively confusing, how about the following?

                    // We perform symlinks resolution on currentPath
                    // under the rationale that the person writing the
                    // original properties file is the one who decided
                    // where the relative includes should resolve.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24465#discussion_r2582103019


More information about the security-dev mailing list